Parse the Phabricator links on other relevant pages as well
ClosedPublic
Actions

Authored by kerberizer on Nov 15 2018, 11:59 AM.

Details

Reviewers

Commits

rUI0064298792b0: Parse the Phabricator links on other relevant pages as well

Summary

D5 implemented parsing the links to Phabricator in JSS 9's summaries only when viewing the history of pages in the MediaWiki and Module namespaces. However, these links appear also in other places, where it is still desirable to convert them to proper hyperlinks:

Special:Contributions/JSS 9,
Special:Recentchanges,
Special:Watchlist,
diff links of pages in NS MediaWiki and Module.

Test Plan

The code behaves as expected in the browser's JS console.

Diff Detail

Repository

rUI JS/CSS User Interface

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kerberizer requested review of this revision.Nov 15 2018, 11:59 AM

kerberizer created this revision.

Harbormaster completed remote builds in B16: Diff 20.Nov 15 2018, 11:59 AM

kerberizer retitled this revision from Parse the Phabricator links on other relevant pages as well. to Parse the Phabricator links on other relevant pages as well.Nov 15 2018, 12:07 PM

kerberizer added a project: JS/CSS User Interface.

Открих си абсурдно глупава грешка. След малко ще кача обновена версия на пача.

D'oh! Selecting on Special:Contributions needs a different method.

Harbormaster completed remote builds in B17: Diff 21.Nov 15 2018, 4:29 PM

$jss9Comments needs not be global, use "var".

Harbormaster completed remote builds in B18: Diff 22.Nov 15 2018, 4:49 PM

Borislav accepted this revision.Nov 17 2018, 1:25 PM

This revision is now accepted and ready to land.Nov 17 2018, 1:25 PM

Closed by commit rUI0064298792b0: Parse the Phabricator links on other relevant pages as well (authored by kerberizer). · Explain WhyNov 17 2018, 3:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			Gadget-ParsePhabLinks.js (83 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20	9bf894a		Nov 15 2018, 11:59 AM	★	★
Diff 2	21	9bf894a	D'oh! Selecting on Special:Contributions needs a different method.	Nov 15 2018, 4:29 PM	★	★
Diff 3	22	9bf894a	$jss9Comments needs not be global, use "var".	Nov 15 2018, 4:49 PM	★	★
Diff 4	23	9bf894a	rUI0064298792b0590cf273080ba884b6ad93609708	Nov 17 2018, 3:54 PM	★	★

Diff 23

View Options

Parse the Phabricator links on other relevant pages as wellClosedPublicActions